Xp. Non-matching programming (Code review).
Everybody wrote a lot about “Pair Programming”. How cool and all that. But as if the problem arises that two programmers write 150% of the work of one programmer per day. Well, that is, theoretically less.
But in our company it was that just for each committer (whoever has the right to add code to the main branch of the program) was assigned a reviewer and after a commit to the trunk (main branch of the program), a ticket (yes !!! every commit should be made on a ticket) translated into a reviewer (the number of commits (s) for this ticket was written on the ticket). The reviewer viewed the changes and either transferred the ticket to the tester or returned it to the committee for one of the reasons: a logical error, failure to comply with coding rules, complex code that cannot be read and it is not documented, well, or he clearly saw an error in the code (eg forgot to trace ).
Thus, both readability was improved - all coding rules were followed, as well as documentation - complex parts of the code were documented.
')
I didn’t have any difficulties while watching someone else’s code, and it didn’t take that long and added a minute of rest to the main work schedule. Plus, in the reviewed code, you could see a lot of tricks that he then applied.
Do you have a similar thread used / used?
UPD. understood my mistake. Renamed the topic.
But in our company it was that just for each committer (whoever has the right to add code to the main branch of the program) was assigned a reviewer and after a commit to the trunk (main branch of the program), a ticket (yes !!! every commit should be made on a ticket) translated into a reviewer (the number of commits (s) for this ticket was written on the ticket). The reviewer viewed the changes and either transferred the ticket to the tester or returned it to the committee for one of the reasons: a logical error, failure to comply with coding rules, complex code that cannot be read and it is not documented, well, or he clearly saw an error in the code (eg forgot to trace ).
Thus, both readability was improved - all coding rules were followed, as well as documentation - complex parts of the code were documented.
')
I didn’t have any difficulties while watching someone else’s code, and it didn’t take that long and added a minute of rest to the main work schedule. Plus, in the reviewed code, you could see a lot of tricks that he then applied.
Do you have a similar thread used / used?
UPD. understood my mistake. Renamed the topic.
Source: https://habr.com/ru/post/42026/
All Articles