Linus Torvalds: “tinydrm looks like refined shit that has never been passed through the compiler”

Thus, Linus described recent patches for the DRM (Direct Rendering Manager) subsystem, which is supervised by David Airlie. The reason for this indignation was the fact that the code sent by D. Eyrly for inclusion in the 4.11 kernel was not trivial.

- The tinydrm code seems to be a compiler. I'm upset, because I expect better quality control. In fact, I’m expecting some driver qualifier to be able to see it.

(tinydrm looks like refined shit that has never been passed through the compiler. I’m angry because I expect better quality control. Let it be some control, while this piece of shit obviously hasn’t been tested at all) .

The compiler sent the compiled code with dozens of warnings and ended with an error, the study of which showed that the code is not going to be assembled if the backlight module is being assembled as a separate module (CONFIG_BACKLIGHT_CLASS_DEVIC = m), and not as part of the kernel. Linus also points out that the patch was sent to the core literally the next day after it was received by the maintainer, which in itself speaks of the quality of testing, even if it were done.

As a temporary measure, Torvalds suggests patches for DRM modules to be sent preliminarily to the linux-next branch, and only then, after careful tests, allow them to be part of the core of the kernel.
')
A source